-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for rosdep checks #10
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
===========================================
+ Coverage 44.57% 78.45% +33.87%
===========================================
Files 13 13
Lines 673 673
Branches 176 176
===========================================
+ Hits 300 528 +228
+ Misses 367 128 -239
- Partials 6 17 +11 ☔ View full report in Codecov by Sentry. |
FIXED |
214dcd1
to
4fb86e4
Compare
4fb86e4
to
4ff02d0
Compare
Back to draft until #14 is merged. |
Ugh, back to draft until #18 is merged. No more "I'll add the tests in a later PR" business. This is ridiculous. |
17a664d
to
e97dcd4
Compare
These are the tests for the previously added rosdep checks. I found that in order to get good coverage, I needed to handle these cases:
To exhaustively accomplish this, I made:
A test is then performed for each violation alone, each violation with the set of "control" changes, and also every possible combination of 2 violations.
Note that we still don't have support for all of the violations we want in this checker, this PR is just to "catch up" on the missing tests.