Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure git.Repo instances are closed #17

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Ensure git.Repo instances are closed #17

merged 2 commits into from
Sep 20, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 19, 2024

This is mostly whitespace changes to use git.Repo instances as a context manager so they're closed properly.

This is mostly whitespace changes to use git.Repo instances as a context
manager so they're closed properly.
@cottsay cottsay added the bug Something isn't working label Sep 19, 2024
@cottsay cottsay self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 38.90%. Comparing base (a3225c3) to head (37586f1).

Files with missing lines Patch % Lines
rosdistro_reviewer/yaml_changes.py 0.00% 3 Missing and 1 partial ⚠️
rosdistro_reviewer/git_lines.py 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   38.90%   38.90%           
=======================================
  Files          12       12           
  Lines         586      586           
  Branches      154      156    +2     
=======================================
  Hits          228      228           
+ Misses        353      352    -1     
- Partials        5        6    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit f110b29 into main Sep 20, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/repo-context branch September 20, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants