Bump libpcl* to 1.14 on Ubuntu Noble #40834

sloretz · 2024-04-25T02:50:01Z

Please add the following dependency to the rosdep database.

Package name:

libpcl-*1.14

Package Upstream Source:

🤷

Purpose of using this:

Point cloud stuff

Distro packaging links:

Links to Distribution Packages

Only changing Ubuntu Noble. Fastest way is to search for libpcl on this page:

https://packages.ubuntu.com/noble/libs/

But here's all the links:

Signed-off-by: Shane Loretz <[email protected]>

Signed-off-by: Chris Lalancette <[email protected]>

clalancette

Yep, this looks good to me. I ended up adding a few more missing keys that we hadn't done for Noble, so this should now be the complete set.

clalancette · 2024-04-25T13:02:58Z

Going ahead and merging this with only one review so we can rebloom what is necessary here.

SteveMacenski · 2024-04-25T15:26:22Z

Doesn't REP 2000 (https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029) reference 1.13.0 as the PCL version of choice for Jazzy?

We were having a discussion on this actually in ros-perception/perception_pcl#448 (comment) for the builds

clalancette · 2024-04-25T15:34:46Z

Doesn't REP 2000 (https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029) reference 1.13.0 as the PCL version of choice for Jazzy?

Yep, good point. I'll go ahead and update that as well.

clalancette · 2024-04-25T15:39:52Z

See ros-infrastructure/rep#402

SteveMacenski · 2024-04-30T20:44:13Z

I have a couple of jobs failing


12:45:29 Traceback (most recent call last):
12:45:29   File "/tmp/ros_buildfarm/scripts/release/create_binarydeb_task_generator.py", line 21, in <module>
12:45:29     run_module('ros_buildfarm.scripts.release.create_binarydeb_task_generator', run_name='__main__')
12:45:29   File "<frozen runpy>", line 229, in run_module
12:45:29   File "<frozen runpy>", line 88, in _run_code
12:45:29   File "/tmp/ros_buildfarm/ros_buildfarm/scripts/release/create_binarydeb_task_generator.py", line 214, in <module>
12:45:29     sys.exit(main())
12:45:29              ^^^^^^
12:45:29   File "/tmp/ros_buildfarm/ros_buildfarm/scripts/release/create_binarydeb_task_generator.py", line 89, in main
12:45:29     debian_pkg_versions = get_binary_package_versions(
12:45:29                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
12:45:29   File "/tmp/ros_buildfarm/ros_buildfarm/common.py", line 179, in get_binary_package_versions
12:45:29     raise KeyError("No packages available for '%s'" % (debian_pkg_name,))
12:45:29 KeyError: "No packages available for 'libpcl-apps1.13'"
12:45:29 Build step 'Execute shell' marked build as failure
12:45:29 $ ssh-agent -k

which I would have thought this update would resolve. I don't think I need to run a new release -- but happy to if I'm wrong

clalancette · 2024-04-30T20:46:49Z

which I would have thought this update would resolve. I don't think I need to run a new release -- but happy to if I'm wrong

Yeah, you need to re-bloom. Those keys are resolved at bloom-time, so they are hard-coded in the debians incorrectly at this point.

SteveMacenski · 2024-04-30T21:34:26Z

Ah ok, easy enough! Thanks. I'll wait until tomorrow when I get my email flood to know all the things I need to touch.

SteveMacenski · 2024-05-01T16:07:48Z

Should I need to cut a new release version in addition to rerunning bloom? When I re-run bloom I get

Could not resolve rosdep key 'libpcl-all' for distro 'noble':
No definition of [libpcl-all] for OS version [noble]
	rosdep key : libpcl-all
	OS name    : ubuntu
	OS version : noble

Where it doesn't list noble in the data (although we all agree its in mainline). Updated, though still on 22.04 - so bloom v0.12.0.

clalancette · 2024-05-01T16:15:52Z

Should I need to cut a new release version in addition to rerunning bloom?

That shouldn't be necessary.

Could not resolve rosdep key 'libpcl-all' for distro 'noble':
No definition of [libpcl-all] for OS version [noble]

Hm, that seems like an out-of-date rosdep database. It is in the upstream:

rosdistro/rosdep/base.yaml

Line 4832 in d3ba89e

    
           noble: [libpcl-apps1.14, libpcl-common1.14, libpcl-features1.14, libpcl-filters1.14, libpcl-io1.14, libpcl-kdtree1.14, libpcl-keypoints1.14, libpcl-ml1.14, libpcl-octree1.14, libpcl-outofcore1.14, libpcl-people1.14, libpcl-recognition1.14, libpcl-registration1.14, libpcl-sample-consensus1.14, libpcl-search1.14, libpcl-segmentation1.14, libpcl-stereo1.14, libpcl-surface1.14, libpcl-tracking1.14, libpcl-visualization1.14]

What package are you trying to release?

SteveMacenski · 2024-05-01T16:30:22Z

That does appear to be the case. I'm trying to release ros2_ouster_driver to R/J now that the pcl 1.14 update landed

clalancette · 2024-05-01T16:45:02Z

That does appear to be the case. I'm trying to release ros2_ouster_driver to R/J now that the pcl 1.14 update landed

Yeah. For what it is worth, it works here for me; it properly resolves that key to the 1.14 version, and I could do a push now.

Can you try running rosdep update first? It shouldn't really be necessary, but I don't see what else could be happening here.

If none of that works, I can do the release for you, but that isn't an ideal situation going forward.

SteveMacenski · 2024-05-01T16:47:43Z

Can you try running rosdep update first?

Done. Still giving me trouble (as expected since that is part of the bloom process), I haven't run into something like this before. Running the release would be appreciated, its a ros2-gbp project so you should have push access.

Hopefully this is a transient issue, I've definitely made rosdep changes and immediately run before without issue. If it occurs again after I make the 24.04 migration for Nav2, then I'll look into it more deeply

clalancette · 2024-05-01T16:52:20Z

Done. Still giving me trouble (as expected since that is part of the bloom process), I haven't run into something like this before. Running the release would be appreciated, its a ros2-gbp project so you should have push access.

I'll go ahead and do the releases.

Oh, a couple of other things:

What files do you have in /etc/ros/rosdep/sources.list.d, and what is the contents? Is there some chance you were playing around with rosdep entries and you are stuck on an older version?
Do you have any of the environment variables set to keep rosdep on an older version (i.e. ROSDISTRO_INDEX_URL)? That could explain why it is pulling an older version.

SteveMacenski · 2024-05-01T17:06:36Z

20-default.list

# os-specific listings first
yaml https://raw.githubusercontent.com/ros/rosdistro/rolling/2024-02-28/rosdep/osx-homebrew.yaml osx

# generic
yaml https://raw.githubusercontent.com/ros/rosdistro/rolling/2024-02-28/rosdep/base.yaml
yaml https://raw.githubusercontent.com/ros/rosdistro/rolling/2024-02-28/rosdep/python.yaml
yaml https://raw.githubusercontent.com/ros/rosdistro/rolling/2024-02-28/rosdep/ruby.yaml
gbpdistro https://raw.githubusercontent.com/ros/rosdistro/rolling/2024-02-28/releases/fuerte.yaml fuerte

# newer distributions (Groovy, Hydro, ...) must not be listed anymore, they are being fetched from the rosdistro index.yaml instead

Ahhhhh that's it. I had to pin it so that we could make rolling on 22.04 work during the interim that the Rolling migration was having the kinks worked out. So this definitely is a transitory issue. I wouldn't have initially thought that bloom would use that and instead grab the main file given the nature of the operation. But this makes sense.

SteveMacenski · 2024-05-13T21:24:25Z

@clalancette I got this done - no worries and thanks for the offer. PRs to come.

Bump libpcl* to 1.14 on Ubuntu Noble

ecf14a4

Signed-off-by: Shane Loretz <[email protected]>

sloretz self-assigned this Apr 25, 2024

sloretz requested a review from a team as a code owner April 25, 2024 02:50

github-actions bot added the rosdep Issue/PR is for a rosdep key label Apr 25, 2024

Add in some more keys that we missed earlier.

de1ac22

Signed-off-by: Chris Lalancette <[email protected]>

clalancette approved these changes Apr 25, 2024

View reviewed changes

clalancette merged commit 3172a84 into master Apr 25, 2024
4 checks passed

clalancette deleted the sloretz__libpcl1.14_noble branch April 25, 2024 13:03

clalancette mentioned this pull request Apr 25, 2024

Package Broken on Noble ros-perception/perception_pcl#448

Closed

This was referenced May 13, 2024

ros2_ouster_drivers: 0.5.1-4 in 'rolling/distribution.yaml' [bloom] #41154

Merged

ros2_ouster_drivers: 0.5.1-5 in 'jazzy/distribution.yaml' [bloom] #41156

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump libpcl* to 1.14 on Ubuntu Noble #40834

Bump libpcl* to 1.14 on Ubuntu Noble #40834

sloretz commented Apr 25, 2024

clalancette left a comment

clalancette commented Apr 25, 2024

SteveMacenski commented Apr 25, 2024 •

edited

Loading

clalancette commented Apr 25, 2024

clalancette commented Apr 25, 2024

SteveMacenski commented Apr 30, 2024 •

edited

Loading

clalancette commented Apr 30, 2024

SteveMacenski commented Apr 30, 2024 •

edited

Loading

SteveMacenski commented May 1, 2024

clalancette commented May 1, 2024

SteveMacenski commented May 1, 2024

clalancette commented May 1, 2024

SteveMacenski commented May 1, 2024 •

edited

Loading

clalancette commented May 1, 2024

SteveMacenski commented May 1, 2024 •

edited

Loading

SteveMacenski commented May 13, 2024

Bump libpcl* to 1.14 on Ubuntu Noble #40834

Bump libpcl* to 1.14 on Ubuntu Noble #40834

Conversation

sloretz commented Apr 25, 2024

Package name:

Package Upstream Source:

Purpose of using this:

Links to Distribution Packages

clalancette left a comment

Choose a reason for hiding this comment

clalancette commented Apr 25, 2024

SteveMacenski commented Apr 25, 2024 • edited Loading

clalancette commented Apr 25, 2024

clalancette commented Apr 25, 2024

SteveMacenski commented Apr 30, 2024 • edited Loading

clalancette commented Apr 30, 2024

SteveMacenski commented Apr 30, 2024 • edited Loading

SteveMacenski commented May 1, 2024

clalancette commented May 1, 2024

SteveMacenski commented May 1, 2024

clalancette commented May 1, 2024

SteveMacenski commented May 1, 2024 • edited Loading

clalancette commented May 1, 2024

SteveMacenski commented May 1, 2024 • edited Loading

SteveMacenski commented May 13, 2024

SteveMacenski commented Apr 25, 2024 •

edited

Loading

SteveMacenski commented Apr 30, 2024 •

edited

Loading

SteveMacenski commented Apr 30, 2024 •

edited

Loading

SteveMacenski commented May 1, 2024 •

edited

Loading

SteveMacenski commented May 1, 2024 •

edited

Loading