clearpath_common: 2.0.0-1 in 'jazzy/distribution.yaml' [bloom] #44213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-helpchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
sloretz
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
- At least one of the following must be present
- Top level license file:
- Per package license files
- License is OSI-approved:
- License correctly listed in package.xmls
- Public source repo:
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions (yes, except project_bringup and project_description, but those are not being released)
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>clearpath_common</name>
<name>clearpath_control</name>
<name>project_bringup</name>
<name>project_description</name>
<name>clearpath_customization</name>
<name>clearpath_description</name>
<name>clearpath_generator_common</name>
<name>clearpath_manipulators</name>
<name>clearpath_manipulators_description</name>
<name>clearpath_mounts_description</name>
<name>clearpath_platform_description</name>
<name>clearpath_sensors_description</name>License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license[^>]*>" "{}" "+"
./clearpath_common/package.xml: <license>BSD</license>
./clearpath_control/package.xml: <license>BSD</license>
./clearpath_customization/project_bringup/package.xml: <license>BSD-3-Clause</license>
./clearpath_customization/project_description/package.xml: <license>BSD-3-Clause</license>
./clearpath_customization/package.xml: <license>BSD</license>
./clearpath_description/package.xml: <license>BSD</license>
./clearpath_generator_common/package.xml: <license>BSD</license>
./clearpath_manipulators/package.xml: <license>BSD</license>
./clearpath_manipulators_description/package.xml: <license>BSD</license>
./clearpath_mounts_description/package.xml: <license>BSD</license>
./clearpath_platform_description/package.xml: <license>BSD</license>
./clearpath_sensors_description/package.xml: <license>BSD</license>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing version of package(s) in repository
clearpath_commonto2.0.0-1:jazzy/distribution.yaml0.12.0nullclearpath_bt_joy
clearpath_common
clearpath_control
clearpath_customization
clearpath_description
clearpath_generator_common
clearpath_manipulators
clearpath_manipulators_description
clearpath_mounts_description
clearpath_platform_description
clearpath_sensors_description