Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --contains-pkgs=.. option to history list and info #1980

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Jan 3, 2025

Closes: #667

Also enhances description of `group` `--contains-pkgs=..` option and
history command changes.
@kontura kontura force-pushed the history-contains-pkgs branch from b0e70bc to bcb5a5b Compare January 10, 2025 06:44
When the default value of the transaction ID argument is only `last`
users searching for transactions with specific packages might be confused
why the output is empty.

For example:
```
$ dnf5 history info --contains-pkgs=htop
```
Would search only the last transaction. On the other hand `list` works as
expected:
```
$ dnf5 history list --contains-pkgs=htop
```
It searches all transactions becuase the default for `list` is all
transactions.
@kontura kontura force-pushed the history-contains-pkgs branch from bcb5a5b to 0e73f49 Compare January 10, 2025 06:46
@kontura kontura marked this pull request as ready for review January 10, 2025 06:47
@kontura
Copy link
Contributor Author

kontura commented Jan 10, 2025

I updated the PR to keep the current history info behavior (showing only the last transaction) but I have added a specific hint when filtered out.

It still bothers me a little that all the other dnf5 info subcommands default to printing all elements so I am open to discussing this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dnf5 history" cannot search by a package name
1 participant