Fix colon in bash completion #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure there is no collision with global variables in other scripts, the global variable "dnf_target" was removed and "complete_cmds" was renamed to "_complete_dnf5_cmds".
Word completion may behave improperly if there is a colon in the word
to be completed. The colon can be special to readline's word completion
code: it can be one of the characters that breaks words for
the completer.
The current set of completion word break characters is available in bash
as the value of the COMP_WORDBREAKS variable. Removing ':' from that
value is enough to make the colon not special to completion:
COMP_WORDBREAKS=${COMP_WORDBREAKS//:}
This fix is workaround for cases where ':' is a break character (it is
contained in COMP_WORDBREAKS). A side effect in this case is the removal
of the prefix containing the colon in the list of bash completion
suggestions.
evan-goode
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Awesome, I ran into this while testing #1983 but assumed it was a bug in my Bash configuration. I think this is a reasonable workaround. LGTM.
Merged
via the queue into
rpm-software-management:main
with commit Jan 8, 2025
f6b851a
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1982
Word completion may behave improperly if there is a colon in the word to be completed. The colon can be special to readline's word completion code: it can be one of the characters that breaks words for the completer.
The current set of completion word break characters is available in bash as the value of the
COMP_WORDBREAKSvariable. Removing:from that value is enough to make the colon not special to completion:COMP_WORDBREAKS=${COMP_WORDBREAKS//:}This fix is workaround for cases where
:is a break character (it is contained inCOMP_WORDBREAKS). A side effect in this case is the removal of the prefix containing the colon in the list of bash completion suggestions.