TypeScript: Add type null to Item properties
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As can be verified in source code, the properties `Item#msgctxt` and `Item#msgid_plural` will be initialized to `null` instead of `undefined` (https://github.com/rubenv/pofile/blob/master/lib/po.js#L279-L281). However, type `undefined` should remain to not break any existing code.
|
Shouldn't the question mark be dropped when you explicitly add |
|
I followed other projects here that explicitly added the "undefined" type to optional props withregards to compiler option "exactOptionalPropertyTypes", e.g. DefinitelyTyped/DefinitelyTyped#54256 The question mark is needed if class So I would be happy to adapt the PR to remove the question marks if you like. |
|
Anybody around here in this project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be verified in source code, the properties
Item#msgctxtandItem#msgid_pluralwill be initialized tonullinstead ofundefined(https://github.com/rubenv/pofile/blob/master/lib/po.js#L279-L281). However, typeundefinedshould remain to not break any existing code.