Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ensure ConnectivityManager is available before other plugins #101

Open
wants to merge 6 commits into
base: feat/sdk-2850-implementation-network-observer
Choose a base branch
from

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Jan 8, 2025

Description

  • In this PR, we have refactored the setup logic of both the modules to ensure ConnectivityObserver is initialised first in the setup process.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactor/optimization

Implementation Details

Refactored both Android and core modules Analytics class.

Checklist

  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation (if appropriate).
  • I have ensured that my code follows the project's code style.
  • I have checked for potential performance impacts and optimized if necessary.
  • I have checked the code for security issues.
  • I have updated the changelog (if required).

How to test?

Run the app and observe events are made correctly.

Breaking Changes

Maintainers Checklist

  • The code has been reviewed.
  • CI tests have passed.
  • All necessary documentation has been updated.

Screenshots (if applicable)

Additional Context

…s are initialised

This refactor is primarily needed to ensure SourceConfig is fetched after ConnectivityObserver is initialised in the Android module.
@1abhishekpandey 1abhishekpandey self-assigned this Jan 8, 2025
…work-observer' into refactor/sdk-2850-ensure-connectivity-manager-is-available-early
…work-observer' into refactor/sdk-2850-ensure-connectivity-manager-is-available-early
…work-observer' into refactor/sdk-2850-ensure-connectivity-manager-is-available-early
…work-observer' into refactor/sdk-2850-ensure-connectivity-manager-is-available-early
@1abhishekpandey 1abhishekpandey marked this pull request as ready for review January 9, 2025 14:30
…work-observer' into refactor/sdk-2850-ensure-connectivity-manager-is-available-early
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant