-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve kotlin sdk #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this method is not utilised.
Currently there is no API to save Float values.
This was previously set to internal but not used anywhere else other than the current class.
Note: This is just to improve the readability. As the class is internal, we are not really changing anything.
Note: This is just to improve the readability. As the class is internal, we are not really changing anything.
Note: This is just to improve the readability. As the class is internal, we are not really changing anything.
Note: This is just to improve the readability. As the class is internal, we are not really changing anything.
…n with InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
Currently, SDK cannot change it's util method, if user get dependent on this.
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
As this class is not used anywhere.
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
By either marking method as internal or adding InternalRudderApi annotation
… class By either marking method as internal or adding InternalRudderApi annotation
This is to ensure that this method can be utilised in future even in android module.
vgupta98
approved these changes
Jan 9, 2025
ChryssaAliferi
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Implementation Details
Improve comments
Remove stale methods
delete
method andfloat
support, as both of them are not utilised anywhere.JsonObjectBuilder.putAll
, as it is no longer required, after replacing its usage withmergeWithHigherPriorityTo
.Change modifier - Make it internal/private or add @InternalRudderApi annotation
Decouple sample app custom plugins from the Kotlin SDK
Utils
methodAndroidAdvertisingIdPlugin.kt
by refactoring the code so that it is not dependent on the Kotlin SDK Utils method. It'll ensure that we can modify our Kotlin SDK Utils method as and when needed.Refactor test classes
putAll
withmergeWithHigherPriorityTo
.Checklist
How to test?
Breaking Changes
Maintainers Checklist
Screenshots (if applicable)
Additional Context
I've skipped a few classes e.g., PluginChain related classes for now.