-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add tests for processor worker #4884
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4884 +/- ##
==========================================
- Coverage 74.42% 74.39% -0.03%
==========================================
Files 427 427
Lines 49655 49655
==========================================
- Hits 36955 36942 -13
- Misses 10266 10275 +9
- Partials 2434 2438 +4 ☔ View full report in Codecov by Sentry. |
Description
Add tests for processor worker to test the logic of merging storeMessages.
If jobSplitter splits a batch to multiple sub batches(subJobs) we merge the results of each subjob into a final storeMessage struct. Whenever a new field is introduced in storeMessage struct we need to update the merge function accordingly. If we missed to update merge function we might miss to store that data.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1280/add-tests-for-processor-worker-to-store-mtu
Security