-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: flipping SourceID & OriginalSourceID during transformation #4887
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4887 +/- ##
==========================================
+ Coverage 74.51% 74.53% +0.01%
==========================================
Files 428 428
Lines 49737 49749 +12
==========================================
+ Hits 37063 37079 +16
- Misses 10238 10248 +10
+ Partials 2436 2422 -14 ☔ View full report in Codecov by Sentry. |
There is no need to merge this one, right? Shall we convert it to draft just in case? |
It is better we merge this. Since we have a lot of customer using sourceID in their user transformations |
processor/transformer/transformer.go
Outdated
event.Metadata.OriginalSourceID = originalSourceID | ||
} | ||
} | ||
for _, event := range response.FailedEvents { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both these flip back
s can be moved to the (*handle)transform(...) Response
method at the end where we populate the Response
(failedEvents
and outClientEvents
).
Also change the description and PR name since we're going to merge it anyway. |
@coderabbitai summary |
Actions performedSummary regeneration triggered. |
Description
In this PR, we are flipping the
OriginalSourceID
andSourceID
during the transformation and flipping them back once the transformation is done. This is to support replays where transformation can be based on the SourceId of a particular source which we are trying to replay.Security