-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include extra columns for errors reporting table #4891
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
- add db migration script to include new columns in error_detail_reports table - refactor reporting types
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4891 +/- ##
==========================================
- Coverage 74.45% 74.36% -0.09%
==========================================
Files 428 428
Lines 49737 49751 +14
==========================================
- Hits 37031 36998 -33
- Misses 10259 10307 +48
+ Partials 2447 2446 -1 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,4 @@ | |||
ALTER TABLE error_detail_reports | |||
ADD COLUMN IF NOT EXISTS sample_event JSONB DEFAULT '{}'::JSONB, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No a blocker, but an FYI:
We are considering using TEXT, if we are not planning to query the json in the database, to avoid potential parsing/validation issues with POSTGRES.
ADD COLUMN IF NOT EXISTS sample_event JSONB DEFAULT '{}'::JSONB, | |
ADD COLUMN IF NOT EXISTS sample_event TEXT DEFAULT '{}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are not planning to query the json in the database
We are looking to query json in DB 😅
@satishrudderstack , do we need to worry about anything on reporting side wrt size? cc: @sanpj2292 |
@ktgowtham @sanpj2292 Right now, the |
Description
errors
tableLinear Ticket
Resolves INT-1056
Security