Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include extra columns for errors reporting table #4891

Merged
merged 8 commits into from
Jul 22, 2024

Conversation

sanpj2292
Copy link
Contributor

Description

  • Adding columns for errors table
    • sampleResponse
    • sampleEvent
    • eventType
    • eventName

Linear Ticket

Resolves INT-1056

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented Jul 12, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

- add db migration script to include new columns in error_detail_reports table
- refactor reporting types
@sanpj2292 sanpj2292 requested review from ItsSudip and koladilip July 12, 2024 07:56
@sanpj2292 sanpj2292 self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (118d01a) to head (45a1115).

Files Patch % Lines
enterprise/reporting/error_reporting.go 48.38% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4891      +/-   ##
==========================================
- Coverage   74.45%   74.36%   -0.09%     
==========================================
  Files         428      428              
  Lines       49737    49751      +14     
==========================================
- Hits        37031    36998      -33     
- Misses      10259    10307      +48     
+ Partials     2447     2446       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktgowtham ktgowtham requested review from mihir20 and ktgowtham July 18, 2024 11:04
@@ -0,0 +1,4 @@
ALTER TABLE error_detail_reports
ADD COLUMN IF NOT EXISTS sample_event JSONB DEFAULT '{}'::JSONB,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No a blocker, but an FYI:

We are considering using TEXT, if we are not planning to query the json in the database, to avoid potential parsing/validation issues with POSTGRES.

Suggested change
ADD COLUMN IF NOT EXISTS sample_event JSONB DEFAULT '{}'::JSONB,
ADD COLUMN IF NOT EXISTS sample_event TEXT DEFAULT '{}',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are not planning to query the json in the database

We are looking to query json in DB 😅

@ktgowtham
Copy link
Contributor

@satishrudderstack , do we need to worry about anything on reporting side wrt size? cc: @sanpj2292

@satishrudderstack
Copy link
Contributor

@satishrudderstack , do we need to worry about anything on reporting side wrt size? cc: @sanpj2292

@ktgowtham @sanpj2292 Right now, the errors table on reporting is ~40GB with 31 days retention. With event_name cardinality and sample_event, I think it would grow big. I think we can enable and keep an eye on the table size on TimescaleDB.

@sanpj2292 sanpj2292 enabled auto-merge (squash) July 22, 2024 07:28
@sanpj2292 sanpj2292 merged commit 6ca22ca into master Jul 22, 2024
51 checks passed
@sanpj2292 sanpj2292 deleted the chore.include-extra-cols-errors-tbl branch July 22, 2024 07:40
This was referenced Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants