Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulk add columns #5358

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: bulk add columns #5358

merged 1 commit into from
Dec 10, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Dec 9, 2024

Description

  • Since we are now handling errors during Polling (earlier we used to mark it as aborted instead of marking it as failed), We can call AddColumns with all the necessary columns.
    • In case some columns already exist (maybe another instead added them), we will get an error and will mark these jobs as a failure. They will be picked up again.

Linear Ticket

  • Resolves WAR-115

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (446666b) to head (52c5e5a).
Report is 1 commits behind head on release/1.39.x.

Files with missing lines Patch % Lines
...yncdestinationmanager/snowpipestreaming/channel.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.39.x    #5358      +/-   ##
==================================================
- Coverage           74.81%   74.76%   -0.05%     
==================================================
  Files                 437      437              
  Lines               61230    61240      +10     
==================================================
- Hits                45807    45787      -20     
- Misses              12894    12915      +21     
- Partials             2529     2538       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the chore.add-columns-in-one-go branch from 56219a5 to 639b73f Compare December 10, 2024 05:49
@achettyiitr achettyiitr changed the base branch from master to release/1.39.x December 10, 2024 05:50
@achettyiitr achettyiitr changed the title chore: add columns in one go instead of adding it single fix: bulk add columns Dec 10, 2024
@achettyiitr achettyiitr force-pushed the chore.add-columns-in-one-go branch from 639b73f to 52c5e5a Compare December 10, 2024 05:54
@cisse21 cisse21 merged commit f05fa25 into release/1.39.x Dec 10, 2024
58 checks passed
@cisse21 cisse21 deleted the chore.add-columns-in-one-go branch December 10, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants