Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify backoff #5409

Closed
wants to merge 1 commit into from
Closed

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jan 6, 2025

Description

  • Simplify backoff by using nextBackoff time.Time within the Manager struct itself.

@achettyiitr achettyiitr marked this pull request as draft January 6, 2025 07:56
@achettyiitr achettyiitr force-pushed the war-72-backoff-1 branch 2 times, most recently from 0612547 to d8975a5 Compare January 6, 2025 08:19
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (b5a1417) to head (d9c2ecd).
Report is 1 commits behind head on war-72-backoff.

Additional details and impacted files
@@                Coverage Diff                 @@
##           war-72-backoff    #5409      +/-   ##
==================================================
- Coverage           74.80%   74.79%   -0.02%     
==================================================
  Files                 438      438              
  Lines               61404    61402       -2     
==================================================
- Hits                45935    45925      -10     
- Misses              12931    12936       +5     
- Partials             2538     2541       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr closed this Jan 8, 2025
@achettyiitr achettyiitr deleted the war-72-backoff-1 branch January 8, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant