fix: Use VsockAddr instead of cid and port where appropiate #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the API of tokio where `bind` and `connect` take an `addr` argument instead of a separate IP/hostname and port. Tokio actually takes a `addr: impl ToSockAddrs` because of DNS resolution (ie. `localhost` can be both `127.0.0.1` and `::1` or any number of IPs for that matter). Vsocks do not do this so it makes sense to keep the argument the same (although we could take `addr: impl Into<Vsock>` instead in case we add some interesting `From` and `TryFrom` methods). Signed-off-by: Jalil David Salamé Messina <[email protected]>
qwandor
approved these changes
Dec 5, 2023
mxpv
approved these changes
Dec 7, 2023
qwandor
added a commit
that referenced
this pull request
Jan 17, 2024
Bump the major version for API changes in #30 and #40. Signed-off-by: Andrew Walbran <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the API of tokio where
bindandconnecttake anaddrargument instead of a separate IP/hostname and port.Tokio actually takes a
addr: impl ToSockAddrsbecause of DNS resolution (ie.localhostcan be both127.0.0.1and::1or any number of IPs for that matter). Vsocks do not do this so it makes sense to keep the argument the same (although we could takeaddr: impl Into<Vsock>instead in case we add some interestingFromandTryFrommethods).