Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: definitely no longer alpha quality #48

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

dpeckett
Copy link
Contributor

@dpeckett dpeckett commented May 15, 2024

Given tokio-vsock has been used in production for a number of years now, it's definitely no longer alpha quality (which was a comment I added to the README, when I initially released the project as a PoC).

Addresses: #44

@dpeckett dpeckett force-pushed the dpeckett/mark_stable branch 2 times, most recently from f455fc2 to a0ca915 Compare May 15, 2024 08:40
Given tokio-vsock is used in production, it's no longer alpha quality.

Signed-off-by: Damian Peckett <[email protected]>
Copy link
Contributor

@jalil-salame jalil-salame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might've missed the --sign-off when making this commit, otherwise it looks good to me c:

Edit: it looks like you didn't wrap the body at 72 characters

@dpeckett dpeckett force-pushed the dpeckett/mark_stable branch from a0ca915 to 558fcc5 Compare May 15, 2024 08:44
@dpeckett
Copy link
Contributor Author

Commit body length limit ;), but thanks for the quick review!

@dpeckett dpeckett merged commit 2a52fae into master May 15, 2024
2 checks passed
@jalil-salame jalil-salame deleted the dpeckett/mark_stable branch May 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants