Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(errors): improve message and add logging when sending tree from backend panics #314

Merged
merged 8 commits into from
Oct 9, 2024
Merged

refactor(errors): improve message and add logging when sending tree from backend panics #314

merged 8 commits into from
Oct 9, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Oct 5, 2024 •
edited
Loading

Related #239
Related #209

@simonsan simonsan added C-bug Category: Something isn't working as expected I-panic labels Oct 5, 2024
@simonsan simonsan requested a review from aawsome October 5, 2024 18:41
@simonsan simonsan added the S-waiting-for-review Status: PRs waiting for review label Oct 5, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.6%. Comparing base (b5fda12) to head (5614921).

Files with missing lines Patch % Lines
crates/core/src/blob/tree.rs 50.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/blob/tree.rs 59.6% <50.0%> (+<0.1%) ⬆️

... and 7 files with indirect coverage changes

@simonsan simonsan marked this pull request as draft October 6, 2024 20:57
@simonsan simonsan mentioned this pull request Oct 6, 2024
Draft
7 tasks
@simonsan simonsan changed the title fix(errors): add error logging when sending tree from backend refactor(errors): improve message when sending tree from backend panics Oct 6, 2024
@simonsan simonsan marked this pull request as ready for review October 6, 2024 22:34
@simonsan simonsan changed the title refactor(errors): improve message when sending tree from backend panics refactor(errors): improve message and add logging when sending tree from backend panics Oct 6, 2024
@simonsan simonsan requested a review from aawsome October 7, 2024 00:47
@simonsan simonsan added this to the NEXT milestone Oct 7, 2024
@aawsome aawsome added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 428fa7a Oct 9, 2024
22 checks passed
@aawsome aawsome deleted the fix/239 branch October 9, 2024 07:21
@rustic-release-plz rustic-release-plz bot mentioned this pull request Oct 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@rustic-release-plz
chore(rustic_core): release v0.5.2 (#312)
0f61e3c 
## 🤖 New release
* `rustic_core`: 0.5.1 -> 0.5.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`
<blockquote>

##
[0.5.2](rustic_core-v0.5.1...rustic_core-v0.5.2)
- 2024-10-09

### Fixed

- *(errors)* use correct error variant for data encryption
([#323](#323))
- *(errors)* handle out of bounds access in PathList display
([#313](#313))
- *(errors)* better error message for hot/cold repo in check
([#297](#297))

### Other

- *(commands)* decouple logic from option structs for check, prune,
repair, key, and restore
([#317](#317))
- *(errors)* improve message and add logging when sending tree from
backend panics
([#314](#314))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
@simonsan simonsan mentioned this pull request Oct 10, 2024
Merged
simonsan added a commit that referenced this pull request Oct 10, 2024
@simonsan
Revert "refactor(errors): improve message and add logging when sendin…
81c127e 
…g tree from backend panics" (#325)

Reverts #314
Related rustic-rs/rustic#1313
@simonsan simonsan mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aawsome aawsome aawsome approved these changes

Assignees
No one assigned
Labels
C-bug Category: Something isn't working as expected I-panic S-waiting-for-review Status: PRs waiting for review
Projects
None yet
Milestone
NEXT
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsan @aawsome