-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: refactor!: use same paths representation for unix/windows #390
Open
aawsome
wants to merge
17
commits into
main
Choose a base branch
from
typed_path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aawsome
force-pushed
the
typed_path
branch
2 times, most recently
from
December 29, 2024 14:35
dbc9dab
to
32ae757
Compare
aawsome
changed the title
WIP: use same paths representation for unix/windows
WIP: refactor!: use same paths representation for unix/windows
Dec 29, 2024
aawsome
force-pushed
the
typed_path
branch
2 times, most recently
from
January 12, 2025 08:20
a9d526f
to
af6ae1c
Compare
aawsome
force-pushed
the
typed_path
branch
2 times, most recently
from
January 13, 2025 12:58
dffed09
to
16eab70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use typed_path to use a common path representation on windows/unix. This will increase windows compatibility and makes testing easier.
TODO:
unwrap
s when converting to/fromstd::path::Path/PathBuf
UnixPath