Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor!: use same paths representation for unix/windows #390

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Dec 24, 2024

Use typed_path to use a common path representation on windows/unix. This will increase windows compatibility and makes testing easier.

TODO:

  • remove unwraps when converting to/from std::path::Path/PathBuf
  • globset support for UnixPath
  • unit tests

@aawsome aawsome force-pushed the typed_path branch 2 times, most recently from dbc9dab to 32ae757 Compare December 29, 2024 14:35
@aawsome aawsome changed the title WIP: use same paths representation for unix/windows WIP: refactor!: use same paths representation for unix/windows Dec 29, 2024
@aawsome aawsome force-pushed the typed_path branch 2 times, most recently from a9d526f to af6ae1c Compare January 12, 2025 08:20
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 46.19289% with 106 lines in your changes missing coverage. Please review.

Project coverage is 43.7%. Comparing base (13587a2) to head (07c4418).

Files with missing lines Patch % Lines
crates/core/src/backend/local_destination.rs 0.0% 27 Missing ⚠️
crates/core/src/commands/backup.rs 33.3% 18 Missing ⚠️
crates/core/src/commands/restore.rs 0.0% 14 Missing ⚠️
crates/core/src/blob/tree.rs 48.0% 13 Missing ⚠️
crates/core/src/vfs.rs 42.8% 12 Missing ⚠️
crates/core/src/util.rs 58.3% 10 Missing ⚠️
crates/core/src/backend/ignore.rs 75.0% 2 Missing ⚠️
crates/core/src/backend/node.rs 81.8% 2 Missing ⚠️
crates/core/src/repofile/snapshotfile.rs 33.3% 2 Missing ⚠️
crates/core/src/archiver/tree.rs 93.3% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/archiver.rs 61.3% <100.0%> (+1.5%) ⬆️
crates/core/src/archiver/parent.rs 65.7% <100.0%> (+1.4%) ⬆️
crates/core/src/archiver/tree_archiver.rs 67.1% <100.0%> (ø)
crates/core/src/backend/childstdout.rs 75.0% <100.0%> (ø)
crates/core/src/repository/command_input.rs 64.0% <ø> (ø)
crates/core/tests/integration.rs 85.1% <100.0%> (+0.5%) ⬆️
crates/core/src/archiver/tree.rs 74.1% <93.3%> (+16.6%) ⬆️
crates/core/src/backend.rs 53.3% <66.6%> (ø)
crates/core/src/backend/stdin.rs 0.0% <0.0%> (ø)
crates/core/src/commands/cat.rs 0.0% <0.0%> (ø)
... and 11 more

... and 15 files with indirect coverage changes

@aawsome aawsome force-pushed the typed_path branch 2 times, most recently from dffed09 to 16eab70 Compare January 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant