Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade ui base container to nodejs v23 #282

Merged
merged 2 commits into from
Jan 4, 2025
Merged

feat: upgrade ui base container to nodejs v23 #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a1b643
feat: upgrade ui base container to nodejs v23
saidsef Jan 2, 2025
ae70e4c
fix: remove nginx ingress annotations
saidsef Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions deployment/k8s/nginx-ingress/ingress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ metadata:
nginx.ingress.kubernetes.io/proxy-connect-timeout: "3600"
nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
nginx.ingress.kubernetes.io/configuration-snippet: |
server_tokens off;
location /metrics {
deny all;
return 301 /;
}
spec:
rules:
- host: tika-ui
Expand Down
2 changes: 1 addition & 1 deletion ui/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/node:22-alpine3.20
FROM docker.io/node:23-alpine3.20

LABEL org.opencontainers.image.authors="Said Sef <[email protected]> (saidsef.co.uk/)"
LABEL org.opencontainers.image.source="https://github.com/saidsef/tika-document-to-text"
Expand All @@ -8,12 +8,12 @@
USER root

## PRODUCTION MODE
ENV NODE_ENV production

Check warning on line 11 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV NPM_CONFIG_FETCH_RETRIES 10

Check warning on line 12 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV NPM_CONFIG_LOGLEVEL warn

Check warning on line 13 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV NPM_CONFIG_CACHE /app

Check warning on line 14 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PORT ${POST:-8080}

Check warning on line 15 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$POST'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 15 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PROTOCOL ${PROTOCOL:-'http'}

Check warning on line 16 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$PROTOCOL'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 16 in ui/Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

WORKDIR /app

Expand Down
Loading