forked from facebookresearch/aepsych
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make prediction query actually work with the probability_space option. (
facebookresearch#474) Summary: Pull Request resolved: facebookresearch#474 Prediction query messages used to called a non-existent strategy method called predict_probability. This meant that there would be an exception whenever this is tried. The method hasn't existed for at least 2 years. Fixed to use `strat.predict()` with the correct probability_space flag instead. Because of this change, further changes was necessary to ensure models that would return tneors with gradients would work (e.g., pairwise probit). Reviewed By: crasanders Differential Revision: D66997335 fbshipit-source-id: e8243ea08e8bcb37814f5275577d9fb1046408ed
- Loading branch information
1 parent
62aab89
commit 28243d7
Showing
3 changed files
with
19 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters