Fix test: tests/pytests/integration/states/test_file.py on windows #67175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the version check for patch in test_file.py. It was expecting the version string to be the 2nd string in the output, but it can be the 3rd. Updated the parsing to just get the last string on the first line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the version check for patch in test_file.py. It was expecting the version string to be the 2nd string in the output, but it can be the 3rd. Updated the parsing to just get the last string on the first line.
What issues does this PR fix or reference?
#67140
Previous Behavior
Test failed due to the version check fixture throwing an exception when trying to parse the version
New Behavior
Now parses the version correctly. Unfortunately, the version installed is 2.5.9 and the version check is for >= 2.6, so it will now skip the tests. Will open an issue to work out getting a newer version of patch installed.