Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in vcf.h #1870

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Typo in vcf.h #1870

merged 2 commits into from
Jan 16, 2025

Conversation

yuw444
Copy link
Contributor

@yuw444 yuw444 commented Jan 6, 2025

Below are my understandings:

  1. bcf_gt_phased and bcf_gt_unphased encode idx to val
  2. bcf_gt_is_phased and bcf_gt_allele decode val to phase info and idx

For instance, idx = 0(ref), 1, 2, 3(alt)

when phased(|), the corresponding values are
val = 3, 5, 7, 9;

when unphased (\), the corresponding values are
val = 2, 4, 6, 8;

According to vcf: line 1168, I believe val is what the author refers to.

@pd3 pd3 merged commit 7b65da3 into samtools:develop Jan 16, 2025
9 checks passed
@pd3
Copy link
Member

pd3 commented Jan 16, 2025

That's correct. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants