Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to play audio files #153

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Bug fix to play audio files #153

merged 1 commit into from
Dec 7, 2023

Conversation

adamjarling
Copy link
Collaborator

What does this do?

  • Fixes a bug which was overlaying the "audio visualizer" element on top of the video element when playing audio files, thereby not allowing a user to play audio files in the UI.
  • Fix an audio visualizer component bug when a user clicks around to different time values in the video element

image

How to test

  • Spin up the app in local dev environment
  • Test this link and verify you can play the audio file in the UI, and the visualizer appears:

http://localhost:3000/docs/viewer/demo?iiif-content=https://iiif.io/api/cookbook/recipe/0002-mvm-audio/manifest.json

… a bug in the visualizer code when a user clicks around to different time values
Copy link
Member

@markpbaggett markpbaggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamjarling This looks great to me.

I actually noticed this the other day with one of my audio works, but assumed I had broken something in my manifest. Didn't even think to look at zindex.

Screenshot 2023-12-07 at 11 35 06 AM

@adamjarling adamjarling merged commit 6214f6c into main Dec 7, 2023
1 check passed
@adamjarling adamjarling deleted the 4372-audio-bug branch December 7, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants