Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOSS: Partial conversion from vector.data() to Data(vector) #435

Merged
merged 26 commits into from
Feb 16, 2024
Merged

IOSS: Partial conversion from vector.data() to Data(vector) #435

merged 26 commits into from
Feb 16, 2024

Conversation

gsjaardema
Copy link
Member

The vector.data() method is not guaranteed to return nullptr if vector is empty. Use a template wrapper function to guarantee the expected nullptr return for empty vectors.

gsjaardema and others added 26 commits February 12, 2024 17:14
@gsjaardema
IOSS: Partial conversion from vector.data() to Data(vector)
ded1cde
@gsjaardema
IOSS: fix incorrect data macro uses
c39116b
@gsjaardema
IOSS: More conversion .data() to Data(..); arrays valid now also
110413b
@gsjaardema
IOSS: More conversion .data() to Data(..) -- cgns
2756721
@gsjaardema
IOSS: More conversion .data() to Data(..) -- exodus
63aab83
@gsjaardema
IOSS: More conversion .data() to Data(..)
d89be88 
-- ioss, adioa, exonull, faodel, gen_struc, main, pamgen, text_mesh, utest
@gsjaardema
Merge branch 'master' into IOSS-use-Data-instead-of-data-method
e6a7b09
@gsjaardema
IOSS: Fix a couple bad .data() to Data(..) conversions
b781b1d
@gsjaardema
IOSS: Fix bad data() -> Data(..) conversion
5325747
@gsjaardema
More conversion .data() to Data(..) -- applications
94a92e6
@gsjaardema
EXODIFF: Fix conversion to vector_data use...
b39d732
@gsjaardema
SUPLIB: Add missing header
83a0c39
@gsjaardema
NEM_SLICE: Make function use vector; more Data conversion
120b43c
@gsjaardema
EPU: More Data conversion
48ac136
@gsjaardema
NEM_SLICE: Replace some functions with algorithms
3a14352
@gsjaardema
More x.data() -> Data(x) conversions
dd1b906
@gsjaardema
NEM_SLICE: Use set_intersection algorithm
24ed20a
@gsjaardema
NEM_SLICE: Clean up code style
0318a26
@gsjaardema
NEM_SLICE: Refactor to reduce Data use
197e1a9
@gsjaardema
NEM_SLICE: Refactor to reduce Data use
35d8d78
@gsjaardema
NEM_SLICE: Add missing header
238cffc
@gdsjaar
NEM_SLICE: Better use of algorithm set_intersection
db6d8d1
@gdsjaar
NEM_SLICE: Fix refactorings; add option to use variant of old method
6ca10be
@gdsjaar
NEM_SLICE: Use old variant for now
3f2ebf5
@gdsjaar
NEM_SLICE: Refactorings were slower; revert to original
390ba11
@gsjaardema
NEM_SLICE: convert x.data() to Data(x)
ae9b6f0
@gsjaardema gsjaardema merged commit 43ab3b3 into master Feb 16, 2024
51 checks passed
@gsjaardema gsjaardema deleted the IOSS-use-Data-instead-of-data-method branch February 16, 2024 23:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsjaardema @gdsjaar