fix(core): duplicate should work with version documents

sanity-io · Jan 18, 2025 · e13884f · e13884f
1 parent b47e306
commit e13884f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 7 deletions.
diff --git a/packages/sanity/src/core/store/_legacy/document/document-pair/editState.ts b/packages/sanity/src/core/store/_legacy/document/document-pair/editState.ts
@@ -45,7 +45,7 @@ export interface EditStateFor {
   /**
    * When editing a version, the name of the release the document belongs to.
    */
-  release?: string
+  release: string | undefined
 }
 const LOCKED: TransactionSyncLockState = {enabled: true}
 const NOT_LOCKED: TransactionSyncLockState = {enabled: false}
@@ -98,7 +98,7 @@ export const editState = memoize(
           liveEditSchemaType,
           ready: !fromCache,
           transactionSyncLock: fromCache ? null : transactionSyncLock,
-          bundleId: idPair.versionId ? getVersionFromId(idPair.versionId) : undefined,
+          release: idPair.versionId ? getVersionFromId(idPair.versionId) : undefined,
         }),
       ),
       startWith({
@@ -111,7 +111,7 @@ export const editState = memoize(
         liveEditSchemaType,
         ready: false,
         transactionSyncLock: null,
-        bundleId: idPair.versionId ? getVersionFromId(idPair.versionId) : undefined,
+        release: idPair.versionId ? getVersionFromId(idPair.versionId) : undefined,
       }),
       publishReplay(1),
       refCount(),

diff --git a/packages/sanity/src/core/store/_legacy/document/document-pair/operations/duplicate.ts b/packages/sanity/src/core/store/_legacy/document/document-pair/operations/duplicate.ts
@@ -1,14 +1,17 @@
 import {omit} from 'lodash'
 
-import {getDraftId} from '../../../../../util'
+import {getDraftId, getVersionFromId, getVersionId} from '../../../../../util'
 import {isLiveEditEnabled} from '../utils/isLiveEditEnabled'
 import {type OperationImpl} from './types'
 
 const omitProps = ['_createdAt', '_updatedAt']
 
 export const duplicate: OperationImpl<[baseDocumentId: string], 'NOTHING_TO_DUPLICATE'> = {
   disabled: ({snapshots}) => {
-    return snapshots.published || snapshots.draft ? false : 'NOTHING_TO_DUPLICATE'
+    if (snapshots.version) return false
+    return snapshots.published || snapshots.draft || snapshots.version
+      ? false
+      : 'NOTHING_TO_DUPLICATE'
   },
   execute: ({schema, client, snapshots, typeName}, dupeId) => {
     const source = snapshots.version || snapshots.draft || snapshots.published
@@ -17,10 +20,19 @@ export const duplicate: OperationImpl<[baseDocumentId: string], 'NOTHING_TO_DUPL
       throw new Error('cannot execute on empty document')
     }
 
+    // When duplicating a version document we need to create it with a version id
+    const versionId = snapshots.version?._id ? getVersionFromId(snapshots.version._id) : null
+    // eslint-disable-next-line no-nested-ternary
+    const _id = versionId
+      ? getVersionId(dupeId, versionId)
+      : isLiveEditEnabled(schema, typeName)
+        ? dupeId
+        : getDraftId(dupeId)
+
     return client.observable.create(
       {
         ...omit(source, omitProps),
-        _id: isLiveEditEnabled(schema, typeName) ? dupeId : getDraftId(dupeId),
+        _id,
         _type: source._type,
       },
       {

diff --git a/packages/sanity/src/structure/documentActions/DuplicateAction.tsx b/packages/sanity/src/structure/documentActions/DuplicateAction.tsx
@@ -21,7 +21,8 @@ const DISABLED_REASON_KEY = {
 }
 
 /** @internal */
-export const DuplicateAction: DocumentActionComponent = ({id, type, onComplete, release}) => {
+export const DuplicateAction: DocumentActionComponent = (props) => {
+  const {id, type, onComplete, release} = props
   const documentStore = useDocumentStore()
   const {duplicate} = useDocumentOperation(id, type, release)
   const {navigateIntent} = useRouter()