-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): handle fieldset members in FormInput
#7045
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Jul 1, 2024 10:20 AM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Fantastic work! Do you mind adding a component test for this? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This pull request fixes an issue where the
FormInput
would not render a field inside a fieldset. The current logic only finds fields that have thekind
of"field"
but does not handle thekind
of"fieldSet"
. The issue can be reproduced by:Adding the following schema with an array field that has a fieldset defined:
Enabling the array tree editing beta feature:
Creating an array item, and the
FormInput
will render this error message:What to review
Notes for release
N/A