remove gophercloud/utils dependency #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
Nuckal777,
defo89,
SuperSandro2000 and
VoigtS
as code owners
majewsky
force-pushed
the
remove-gophercloud-utils-dependency
branch
from
7e6c5b4 to
38f2995
Compare
The main features of gophercloud/utils are support for reading the entire range of OS_* environment variables, and reading clouds.yaml configuration files. You need neither here. While I was at it, I refactored the two occurences of Keystone authentication into a method.
majewsky
force-pushed
the
remove-gophercloud-utils-dependency
branch
from
38f2995 to
93a6a7c
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main features of gophercloud/utils are support for reading the entire range of OS_* environment variables, and reading clouds.yaml configuration files. As far as I can see, you need neither here.
While I was at it, I refactored the two occurences of Keystone authentication into a method.