Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCAT Module #82

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

RCAT Module #82

wants to merge 8 commits into from

Conversation

tanvipotdar
Copy link

Added a module for RCAT which splits petri nets into separate building blocks and outputs elementary rate equations for the building blocks

tanvipotdar and others added 8 commits July 22, 2014 17:06
@tanvipotdar
Update ArcView.java
f9553ff
@tanvipotdar
Update PlaceEditorPanel.java
1426bcb
@tanvipotdar
Update PlaceEditorPanel.java
3549433
@tanvipotdar
Update ArcWeightEditorPanel.java
98a7c80
@tanvipotdar
Enable capacity spinner in the Place Editor
32d3001 
Changed double to int on lines  381, 382 and 487
@tanvipotdar
Implemented the algorithm for splitting a SPN into building blocks.
59446dc 
Added an RCAT module which currently only splits SPNs and informs if RCAT can be run.
@tanvipotdar
Merge branch 'master' of github.com:tanvipotdar/PIPE
f174647
@tanvipotdar
Allowed the list of transitions to be displayed along with the list o…
0031595 
…f places in the building block

Enabled printing of structural conditions of Building Blocks when the petri net is split
Added features to get all arcs (inbound and outbound separately as well) in the building blocks
Added methods to calculate elementary rate equations for a building block which works satisfactorily for MM1 queues but less so for larger building blocks
@sarahtattersall
Copy link
Owner

Overall this is some good work - well done for braving RCAT :)! I've got to pop out so I'll add some more comments to the code later.

My main comments for the overall project though are:

  • There's some formatting issues involving inconsistent spaces, whitespace, new lines etc. I'd preferably like it to be formatted the same as the rest of my project. You can do this with the auto-formatter though so it's super easy!
  • There's a few TODO's that I'm not sure if you actually meant to do
  • I can't be sure that RCAT actually works without seeing some unit/integration tests. There's examples of Cucumber integration tests which you should use to test RCAT works with some pre-defined cases in the analysis modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanvipotdar @sarahtattersall