Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/messages api #546
Feat/messages api #546
Changes from 11 commits
cc424be
e100cd9
3da7578
5507d4a
4fd5161
6beb908
d750798
57796cc
c806b64
46f7798
17673a1
f552c45
8defb64
60b6f17
2e63e47
c07ed29
e152f43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use
any
instead ofinterface{}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not adding
withBetaAssistantV1()
here ? When using CreateMessage I still get the errorYou must provide the 'OpenAI-Beta' header to access the Assistants API. Please try again by setting the header 'OpenAI-Beta: assistants=v1'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lowczarc I ran into this and submitted: #566
Check warning on line 72 in messages.go
Codecov / codecov/patch
messages.go#L71-L72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion: changing
messagesSuffix
from/messages
tomessages
would make formatting more consistent without%s%s
mixed with%s/%s
Check warning on line 107 in messages.go
Codecov / codecov/patch
messages.go#L106-L107
Check warning on line 122 in messages.go
Codecov / codecov/patch
messages.go#L121-L122
Check warning on line 139 in messages.go
Codecov / codecov/patch
messages.go#L138-L139
Check warning on line 154 in messages.go
Codecov / codecov/patch
messages.go#L153-L154
Check warning on line 169 in messages.go
Codecov / codecov/patch
messages.go#L168-L169