-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix future incompatibility report #28
Open
ctrlcctrlv
wants to merge
1
commit into
saurvs:master
Choose a base branch
from
MFEK:fix_future_incompat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following warnings were discovered during the build. These warnings are an indication that the packages contain code that will become an error in a future release of Rust. These warnings typically cover changes to close soundness problems, unintended or undocumented behavior, or critical problems that cannot be fixed in a backwards-compatible fashion, and are not expected to be in wide use. Each warning should contain a link for more information on what the warning means and how to resolve it. To solve this problem, you can try the following approaches: - If the issue is not solved by updating the dependencies, a fix has to be implemented by those dependencies. You can help with that by notifying the maintainers of this problem (e.g. by creating a bug report) or by proposing a fix to the maintainers (e.g. by creating a pull request): - [email protected] - Repository: https://www.github.com/saurvs/nfd-rs - Detailed warning command: `cargo report future-incompatibilities --id 226 --package [email protected]` - If waiting for an upstream fix is not an option, you can use the `[patch]` section in `Cargo.toml` to use your own version of the dependency. For more information, see: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section The package `nfd v0.0.4 (https://github.com/raphlinus/nfd-rs?rev=5e09b79bf511e3a91ae8cefdb96e9734fa4a79c2#5e09b79b)` currently triggers the following future incompatibility lints: > warning: trailing semicolon in macro used in expression position > --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47 > | > 29 | concat!("nativefiledialog/src/", $suf); > | ^ > ... > 37 | cfg.include(nfd!("include")); > | --------------- in this macro invocation > | > = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! > = note: for more information, see issue #79813 <rust-lang/rust#79813> > = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default > = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info) > > warning: trailing semicolon in macro used in expression position > --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47 > | > 29 | concat!("nativefiledialog/src/", $suf); > | ^ > ... > 38 | cfg.file(nfd!("nfd_common.c")); > | -------------------- in this macro invocation > | > = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! > = note: for more information, see issue #79813 <rust-lang/rust#79813> > = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default > = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info) > > warning: trailing semicolon in macro used in expression position > --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47 > | > 29 | concat!("nativefiledialog/src/", $suf); > | ^ > ... > 41 | cfg.file(nfd!("nfd_cocoa.m")); > | ------------------- in this macro invocation > | > = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! > = note: for more information, see issue #79813 <rust-lang/rust#79813> > = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default > = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info) > > warning: trailing semicolon in macro used in expression position > --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47 > | > 29 | concat!("nativefiledialog/src/", $suf); > | ^ > ... > 46 | cfg.file(nfd!("nfd_win.cpp")); > | ------------------- in this macro invocation > | > = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! > = note: for more information, see issue #79813 <rust-lang/rust#79813> > = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default > = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info) > > warning: trailing semicolon in macro used in expression position > --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47 > | > 29 | concat!("nativefiledialog/src/", $suf); > | ^ > ... > 72 | cfg.file(nfd!("nfd_gtk.c")); > | ----------------- in this macro invocation > | > = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! > = note: for more information, see issue #79813 <rust-lang/rust#79813> > = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default > = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info) >
bump - I'd like for this to be merged just because seeing that little warning that a dependency will become incompatible with Rust is annoying |
bump, for the same reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. raphlinus#1