Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move neo4j routing to ingress #2422

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Move neo4j routing to ingress #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions api-gateway/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ gateway:
url: http://demo:5421
demo-cpg:
url: http://demo-cpg:5500
neo4j-browser:
url: http://save-cloud:7474

management:
endpoints:
Expand Down Expand Up @@ -58,12 +56,6 @@ spring:
# If SESSION cookie is passed to downstream, it is then removed, because downstream discards it
- RemoveRequestHeader=Cookie
- AuthorizationHeaders=
- id: neo4j_route
uri: ${gateway.neo4j-browser.url}
predicates:
- Path=/neo4j/browser/**
filters:
- StripPrefix=1
- id: resource_route
uri: ${gateway.frontend.url}
predicates:
Expand Down
9 changes: 9 additions & 0 deletions save-cloud-charts/save-cloud/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,14 @@ spec:
name: {{ .Values.grafana.service.portName }}
pathType: Prefix
path: '/grafana'
- http:
paths:
- backend:
service:
name: {{ .Values.neo4j.browser.serviceName }}
port:
number: {{ .Values.neo4j.browser.port }}
pathType: Prefix
path: '/neo4j/browser'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just /neo4j?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense


{{- end }}
3 changes: 3 additions & 0 deletions save-cloud-charts/save-cloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ loki:

neo4j:
enabled: true
browser:
serviceName: http://save-cloud
port: 7474
ingress:
enabled: false
svc:
Expand Down