Change from JDK9 to JDK11 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Dec 4, 2023
There was a problem hiding this comment.
We no longer test using Travis CI, so maybe we should get CI going first?
There was a problem hiding this comment.
Actually thats the reason for doing this PR first, I wanted to use stable JDK versions for the github actions CI and currently the entire project is hardcoded to use JDK 9.
Idea is after this PR is merged I will immediately set up github actions CI
|
Don't wait for me on reviews, I can't contribute to technical discussion without extra permissions which take time, so go ahead with merging when you're happy. |
eed3si9n
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this project appears to be hardcoded to use JDK 9 as the alternative JDK for multi release, this PR changes this to JDK 11. The main intent behind this change is that JDK 9 is a non LTS release and because of this its actually cumbersome to install on various platforms. This also opens up the project to use github actions for CI.
Due to changes between JDK 9 and JDK 11 there was some additional work that needed to be done to get
sbt scriptedto pass, notable changes areSecurityPolicypolicyfile as well enable theSecurityManager. While theSecurityManagerproblems were solved in later versions of sbt, updating this projects sbt version causes the tests to fail and so its best to solve this problem separately. This change will be reverted once the sbt version is updated to a later one.sourceandtargethad to be changed slightly since the format was updated since JDK 11This PR also adds
-SNAPSHOTto the version we can properly iterate changes and test them.One argument that may pop up is that we are essentially dropping support for JDK9, I think a cleaner/more proper way to solve this would be #24 .
Resolves: #19