forked from facebookarchive/nailgun
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The security manager installed by Nailgun seems to add a noticeable overhead in IO operations. facebookarchive#134 As a result, we don't install a security manager. Nailgun only uses it to trap exit, and in our case we don't need to do that since Bloop doesn't define any `nailShutdown`.
- Loading branch information
Showing
1 changed file
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d32853c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jvican FYI, I came across the same problem today looking at profiles of compilation under IntelliJ's Zinc integration.
/cc @jastice @mkeskells
d32853c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI we use Instrumentation API to intercept rogue System.exit calls.
I think that if we are trying to protect against rogue macros its a cheaper alternative than SecurityManager