Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: BKTCLT-34 Go client: add Prometheus metrics #270

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

jonathan-gramain
Copy link
Contributor

Add metrics when requests are processed, in order for them to be exposed by the API user and scraped by Prometheus.

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2024

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2024

Incorrect fix version

The Fix Version/s in issue BKTCLT-34 contains:

  • 7.10.14

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.14

  • 8.1.11

Please check the Fix Version/s of BKTCLT-34, or the target
branch of this pull request.

@jonathan-gramain
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@jonathan-gramain jonathan-gramain force-pushed the improvement/BKTCLT-34-goClientMetrics branch from e2dfbc9 to 7ada06f Compare December 19, 2024 22:35
@jonathan-gramain jonathan-gramain changed the base branch from development/7.10 to improvement/BKTCLT-35-goClientCustomHTTPClient December 19, 2024 22:35
@jonathan-gramain jonathan-gramain force-pushed the improvement/BKTCLT-34-goClientMetrics branch from eae15ba to 6f8b266 Compare December 27, 2024 04:44
@jonathan-gramain jonathan-gramain force-pushed the improvement/BKTCLT-35-goClientCustomHTTPClient branch from 735087b to ef3bc7c Compare January 15, 2025 19:18
@jonathan-gramain jonathan-gramain force-pushed the improvement/BKTCLT-34-goClientMetrics branch from 6f8b266 to 3c77525 Compare January 15, 2025 19:19
Add metrics when requests are processed, in order for them to be
exposed by the API user and scraped by Prometheus.
@jonathan-gramain jonathan-gramain force-pushed the improvement/BKTCLT-34-goClientMetrics branch from 3c77525 to c0be0a4 Compare January 15, 2025 19:42
@jonathan-gramain jonathan-gramain changed the base branch from improvement/BKTCLT-35-goClientCustomHTTPClient to development/7.10 January 15, 2025 19:42
@jonathan-gramain
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 15, 2025

Conflict

A conflict has been raised during the creation of
integration branch w/8.1/improvement/BKTCLT-34-goClientMetrics with contents from improvement/BKTCLT-34-goClientMetrics
and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/improvement/BKTCLT-34-goClientMetrics origin/development/8.1
 $ git merge origin/improvement/BKTCLT-34-goClientMetrics
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/improvement/BKTCLT-34-goClientMetrics

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 15, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue BKTCLT-34.

Goodbye jonathan-gramain.

The following options are set: approve

@bert-e bert-e merged commit c0be0a4 into development/7.10 Jan 15, 2025
2 checks passed
@jonathan-gramain jonathan-gramain deleted the improvement/BKTCLT-34-goClientMetrics branch January 15, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants