Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/cldsrv 426 acl implicit deny #5419

Closed

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Nov 7, 2023

PR opened after closing : #5323

Bucket policies are not correctly interpreted, this is part of the following epic to fix that: scality/Arsenal#2181

This PR is aiming to update ACL checks for APIs with multiple permission , ticket linked to this issue here : https://scality.atlassian.net/browse/CLDSRV-426

PRs providing implicit Deny logic to CS for processing in this PR
scality/Arsenal#2181
https://github.com/scality/Vault/pull/2135
#5322

  • Tests have also been added.

@bert-e
Copy link
Contributor

bert-e commented Nov 7, 2023

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@benzekrimaha benzekrimaha changed the base branch from development/8.7 to development/7.10 November 7, 2023 11:16
@scality scality deleted a comment from bert-e Nov 7, 2023
@scality scality deleted a comment from bert-e Nov 7, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 7, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-426 contains:

  • 7.10.31

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.33

  • 7.70.30

  • 8.6.12

  • 8.7.31

  • 8.8.5

Please check the Fix Version/s of CLDSRV-426, or the target
branch of this pull request.

@benzekrimaha benzekrimaha deleted the improvement/CLDSRV-426-acl-implicit-Deny branch November 7, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants