INTEGRATION [PR#5456 > development/8.7] CLDSRV-428: put apis updated for implicit deny #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit put apis have been updated to check for implicit deny returned by vault and added as a parameter in the request Object. Tests have also been added for the metadataUtils validateBucket function. MetadataUtils functions have been updated to check for implicit deny. The goal is to implement the same authorization logic as AWS, where an implicit deny from IAM and an Allow from the Bucket Policy should allow the request for example. For the delete on the objectPutCopyPart and objectPutPart as we need to deferentiate between the vault request and the external backend once a delete is applied to the request directly as it's unique per API call this value is then added to the request object. here's the link to the design doc for more details: https://github.com/scality/citadel/blob/development/1.0/docs/design/bucket-policies.md?plain=1#L263
…impDeny' into w/7.70/improvement/CLDSRV-428-put-apis-impDeny
…t-apis-impDeny' into w/8.6/improvement/CLDSRV-428-put-apis-impDeny
…/octopus/w/8.7/improvement/CLDSRV-428-put-apis-impDeny
…provement/CLDSRV-428-put-apis-impDeny
…impDeny' into w/7.70/improvement/CLDSRV-428-put-apis-impDeny
…ovement/CLDSRV-428-put-apis-impDeny
…t-apis-impDeny' into w/8.6/improvement/CLDSRV-428-put-apis-impDeny
…ovement/CLDSRV-428-put-apis-impDeny
…-apis-impDeny' into w/8.7/improvement/CLDSRV-428-put-apis-impDeny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #5456.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.7/improvement/CLDSRV-428-put-apis-impDeny, please follow thisprocedure:
$ git fetch $ git checkout w/8.7/improvement/CLDSRV-428-put-apis-impDeny $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.7/improvement/CLDSRV-428-put-apis-impDenyPlease always comment pull request #5456 instead of this one.