Improvement/cldsrv 430 delete api implicit deny #5470

benzekrimaha · 2023-12-05T11:55:23Z

Bucket policies are not correctly interpreted, this is part of the following epic to fix that: scality/Arsenal#2181

This PR is aiming to update get apis since object and bucket authorisations are made at API level and need to support implicit denies, ticket linked to this issue here : https://scality.atlassian.net/browse/CLDSRV-430

PRs providing implicit Deny logic to CS for processing in this PR
scality/Arsenal#2181
https://github.com/scality/Vault/pull/2135
#5322
#5420
#5432
#5456
#5462

Here CI links for zenko tests :
https://github.com/scality/Zenko/actions/runs/7130054302
https://github.com/scality/Zenko/actions/runs/7130071959
https://github.com/scality/Zenko/actions/runs/7130085996

bert-e · 2023-12-07T07:48:31Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

benzekrimaha · 2023-12-07T09:30:19Z

ping

bert-e · 2023-12-07T09:30:23Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-430 contains:

7.10.36
7.70.34

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

7.10.37
7.70.34
8.6.15
8.7.35
8.8.9

Please check the Fix Version/s of CLDSRV-430, or the target
branch of this pull request.

benzekrimaha · 2023-12-07T09:31:56Z

ping

bert-e · 2023-12-07T09:32:05Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

bert-e · 2023-12-07T13:22:16Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

benzekrimaha · 2023-12-07T13:31:31Z

/create_integration_branches

bert-e · 2023-12-07T13:31:42Z

Conflict

A conflict has been raised during the creation of
integration branch w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny with contents from improvement/CLDSRV-430-delete-api-implicitDeny
and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny origin/development/7.70
 $ git merge origin/improvement/CLDSRV-430-delete-api-implicitDeny
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny

The following options are set: create_integration_branches

benzekrimaha · 2023-12-07T13:33:57Z

ping

bert-e · 2023-12-07T13:34:09Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.6/improvement/CLDSRV-430-delete-api-implicitDeny with contents from w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny
and development/8.6.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.6/improvement/CLDSRV-430-delete-api-implicitDeny origin/development/8.6
 $ git merge origin/w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.6/improvement/CLDSRV-430-delete-api-implicitDeny

The following options are set: create_integration_branches

benzekrimaha · 2023-12-07T14:19:48Z

ping

bert-e · 2023-12-07T14:25:00Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

benzekrimaha · 2023-12-07T14:25:18Z

/create_pull_requests

bert-e · 2023-12-07T14:25:37Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-430-delete-api-implicitDeny into
development/7.10
w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/7.70 (pull request INTEGRATION [PR#5470 > development/7.70] Improvement/cldsrv 430 delete api implicit deny #5471)
w/8.6/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/8.6 (pull request INTEGRATION [PR#5470 > development/8.6] Improvement/cldsrv 430 delete api implicit deny #5472)
w/8.7/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/8.7 (pull request INTEGRATION [PR#5470 > development/8.7] Improvement/cldsrv 430 delete api implicit deny #5473)
w/8.8/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/8.8 (pull request INTEGRATION [PR#5470 > development/8.8] Improvement/cldsrv 430 delete api implicit deny #5474)

The following branches will NOT be impacted:

development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2023-12-07T14:25:40Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2023-12-07T14:28:01Z

@bert-e reset

bert-e · 2023-12-07T14:28:13Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2023-12-07T14:28:23Z

Conflict

A conflict has been raised during the creation of
integration branch w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny with contents from improvement/CLDSRV-430-delete-api-implicitDeny
and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny origin/development/7.70
 $ git merge origin/improvement/CLDSRV-430-delete-api-implicitDeny
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny

The following options are set: create_pull_requests, create_integration_branches

KazToozs

LGTM

lib/api/bucketDeleteCors.js

lib/api/multiObjectDelete.js

lib/api/bucketDelete.js

bert-e · 2023-12-08T14:48:58Z

History mismatch

Merge commit #3303f5c8f77585901a9e300caff2f293db6be0a7 on the integration branch
w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny is merging a branch which is neither the current
branch improvement/CLDSRV-430-delete-api-implicitDeny nor the development branch
development/7.70.

It is likely due to a rebase of the branch improvement/CLDSRV-430-delete-api-implicitDeny and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_pull_requests, create_integration_branches

As for multiObjectDelete,a new function was added to ensure that all actions are allowed.

bert-e · 2023-12-08T17:29:37Z

History mismatch

Merge commit #2eeef31ff587fd0f6b08a3f2783d0c62019c7f56 on the integration branch
w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny is merging a branch which is neither the current
branch improvement/CLDSRV-430-delete-api-implicitDeny nor the development branch
development/7.70.

It is likely due to a rebase of the branch improvement/CLDSRV-430-delete-api-implicitDeny and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2023-12-08T17:30:04Z

@bert-e reset

bert-e · 2023-12-08T17:30:18Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2023-12-08T17:30:28Z

Conflict

A conflict has been raised during the creation of
integration branch w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny with contents from improvement/CLDSRV-430-delete-api-implicitDeny
and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny origin/development/7.70
 $ git merge origin/improvement/CLDSRV-430-delete-api-implicitDeny
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2023-12-08T17:32:55Z

ping

bert-e · 2023-12-08T17:43:38Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-430-delete-api-implicitDeny into
development/7.10
w/7.70/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/7.70 (pull request INTEGRATION [PR#5470 > development/7.70] Improvement/cldsrv 430 delete api implicit deny #5482)
w/8.6/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/8.6 (pull request INTEGRATION [PR#5470 > development/8.6] Improvement/cldsrv 430 delete api implicit deny #5483)
w/8.7/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/8.7 (pull request INTEGRATION [PR#5470 > development/8.7] Improvement/cldsrv 430 delete api implicit deny #5484)
w/8.8/improvement/CLDSRV-430-delete-api-implicitDeny will be merged into development/8.8 (pull request INTEGRATION [PR#5470 > development/8.8] Improvement/cldsrv 430 delete api implicit deny #5485)

The following branches will NOT be impacted:

development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2023-12-08T17:43:39Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2023-12-11T07:53:01Z

/approve

bert-e · 2023-12-11T07:53:28Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/7.10
✔️ development/7.70
✔️ development/8.6
✔️ development/8.7
✔️ development/8.8

The following branches will NOT be impacted:

development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_pull_requests, create_integration_branches

bert-e · 2023-12-11T07:53:41Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/7.10
✔️ development/7.70
✔️ development/8.6
✔️ development/8.7
✔️ development/8.8

The following branches have NOT changed:

development/7.4

Please check the status of the associated issue CLDSRV-430.

Goodbye benzekrimaha.

benzekrimaha force-pushed the improvement/CLDSRV-430-delete-api-implicitDeny branch from ff186d8 to b3ad1e6 Compare December 5, 2023 13:45

Base automatically changed from improvement/CLDSRV-429-get-apis-implicitDeny to development/7.10 December 7, 2023 07:48

scality deleted a comment from bert-e Dec 7, 2023

benzekrimaha force-pushed the improvement/CLDSRV-430-delete-api-implicitDeny branch from 2719387 to 6577286 Compare December 7, 2023 13:30

scality deleted a comment from bert-e Dec 7, 2023

KazToozs approved these changes Dec 7, 2023

View reviewed changes

Seragonia reviewed Dec 8, 2023

View reviewed changes

lib/api/bucketDeleteCors.js Show resolved Hide resolved

lib/api/multiObjectDelete.js Outdated Show resolved Hide resolved

lib/api/bucketDelete.js Outdated Show resolved Hide resolved

benzekrimaha marked this pull request as ready for review December 8, 2023 13:38

benzekrimaha force-pushed the improvement/CLDSRV-430-delete-api-implicitDeny branch from 4c2dd56 to 76b8d1f Compare December 8, 2023 14:48

williamlardier approved these changes Dec 8, 2023

View reviewed changes

benzekrimaha added 2 commits December 8, 2023 18:29

CLDSRV-430: add delete API implicit deny logic

91629a0

As for multiObjectDelete,a new function was added to ensure that all actions are allowed.

CLDSRV-430: version bump

74425d0

benzekrimaha force-pushed the improvement/CLDSRV-430-delete-api-implicitDeny branch from 76b8d1f to 74425d0 Compare December 8, 2023 17:29

scality deleted a comment from bert-e Dec 8, 2023

bert-e merged commit 74425d0 into development/7.10 Dec 11, 2023
13 checks passed

bert-e deleted the improvement/CLDSRV-430-delete-api-implicitDeny branch December 11, 2023 07:53

This was referenced Dec 14, 2023

Improvement/cldsrv 431 misc api implicit deny #5479

Merged

improvement/CLDSRV-451-specific-7.70-apis-update #5495

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/cldsrv 430 delete api implicit deny #5470

Improvement/cldsrv 430 delete api implicit deny #5470

benzekrimaha commented Dec 5, 2023 •

edited

Loading

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

bert-e commented Dec 7, 2023

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

bert-e commented Dec 7, 2023

KazToozs left a comment

bert-e commented Dec 8, 2023

bert-e commented Dec 8, 2023

benzekrimaha commented Dec 8, 2023

bert-e commented Dec 8, 2023

bert-e commented Dec 8, 2023

benzekrimaha commented Dec 8, 2023

bert-e commented Dec 8, 2023

bert-e commented Dec 8, 2023

benzekrimaha commented Dec 11, 2023

bert-e commented Dec 11, 2023

bert-e commented Dec 11, 2023

Improvement/cldsrv 430 delete api implicit deny #5470

Improvement/cldsrv 430 delete api implicit deny #5470

Conversation

benzekrimaha commented Dec 5, 2023 • edited Loading

bert-e commented Dec 7, 2023

Hello benzekrimaha,

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Incorrect fix version

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Request integration branches

bert-e commented Dec 7, 2023

Request integration branches

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Conflict

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Conflict

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Waiting for approval

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Integration data created

bert-e commented Dec 7, 2023

Waiting for approval

benzekrimaha commented Dec 7, 2023

bert-e commented Dec 7, 2023

Reset complete

bert-e commented Dec 7, 2023

Conflict

KazToozs left a comment

Choose a reason for hiding this comment

bert-e commented Dec 8, 2023

History mismatch

bert-e commented Dec 8, 2023

History mismatch

benzekrimaha commented Dec 8, 2023

bert-e commented Dec 8, 2023

Reset complete

bert-e commented Dec 8, 2023

Conflict

benzekrimaha commented Dec 8, 2023

bert-e commented Dec 8, 2023

Integration data created

bert-e commented Dec 8, 2023

Waiting for approval

benzekrimaha commented Dec 11, 2023

bert-e commented Dec 11, 2023

In the queue

bert-e commented Dec 11, 2023

benzekrimaha commented Dec 5, 2023 •

edited

Loading