CLDSRV-598: Add overhreadField to metadata-only operations #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata-only operations (objectPutRetention, objectPutLegalHold, objectPutTagging, objectPutACL) overwrite the metadata of an object. These operations currently do not attach the overheadField to metadata put operations. As a result, the entries in the metadata op log for those operations do not include overhead information, and scuba interprets them as object puts, resulting in wrong metric updates.
dvasilas
force-pushed
the
user/dvasilas/CLDSRV-598
branch
from
1127e02 to
1681dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata-only operations (
objectPutRetention,objectPutLegalHold,objectPutTagging,objectPutACL) overwrite the metadata of an object.These operations currently do not attach the
overheadFieldto metadata put operations.As a result, the entries in the metadata op log for those operations do not include overhead information, and scuba interprets them as object puts, resulting in wrong metric updates.
Issue: CLDSRV-598