CLDSRV-598: Add overhreadField to metadata-only operations

[dvasilas]

Metadata-only operations (objectPutRetention, objectPutLegalHold, objectPutTagging, objectPutACL) overwrite the metadata of an object.

These operations currently do not attach the overheadField to metadata put operations.

As a result, the entries in the metadata op log for those operations do not include overhead information, and scuba interprets them as object puts, resulting in wrong metric updates.

Issue: CLDSRV-598

[bert-e]

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-598 contains:

• 7.70.59

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 7.70.59

• 8.8.40

• 9.0.0

Please check the Fix Version/s of CLDSRV-598, or the target
branch of this pull request.

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

[williamlardier]

As a result, the entries in the metadata op log for those operations do not include overhead information, and scuba interprets them as object puts, resulting in wrong metric updates.

We may want to also review the metadata operations done in backbeat or route backbeat here, just to make sure they doesn't lead to wrong behavior in scuba

[williamlardier]

Also, don't we have the same issue with metadata-only deletes, that also alter the metadata?

[dvasilas]

We may want to also review the metadata operations done in backbeat or route backbeat here, just to make sure they doesn't lead to wrong behavior in scuba.

I created https://scality.atlassian.net/browse/S3C-9618 for that.

Also, don't we have the same issue with metadata-only deletes, that also alter the metadata?

Good point !
I see objectDeleteTagging that should be fixed. Is there another one that I am missing ?

[williamlardier]

I don't see anything else, but maybe @Kerkesni or @francoisferrand will have some

[dvasilas]

I am closing this because this is not the correct fix for the issue.
The fix will be handled by CLDSRV-552