-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-552: Set originOp for putObjectRetention and putObjectLegalHold #5725
Conversation
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -94,6 +94,8 @@ function objectPutLegalHold(authInfo, request, log, callback) { | |||
objectMD.replicationInfo = Object.assign({}, | |||
objectMD.replicationInfo, replicationInfo); | |||
} | |||
// eslint-disable-next-line no-param-reassign | |||
objectMD.originOp = 's3:ObjectLegalHold:Put'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we want to reflect this event back to the client through bucket notifications but in Arsenal we have the supportedNotificationEvents
variable in the lib/constants.ts
file, that might require updates with these new events (if we want to return them).
If we edit arsenal, it should ideally be done before this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed about this with @francoisferrand, and we don't want to add event types in that list that are not in AWSs' list of supported event types: https://docs.aws.amazon.com/AmazonS3/latest/userguide/notification-how-to-event-types-and-destinations.html .
Basically, if AWS does not send notifications for those operations (I checked that), we should not either.
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
/approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-552. Goodbye dvasilas. The following options are set: approve, create_integration_branches |
putObjectRetention
andputObjectLegalHold
operations do not set theoriginOp
metadata field and as a result copy theoriginOp
of the previous operation on the object (e.g.s3:ObjectCreated
).Issue: CLDSRV-552