Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debloated pkg #3139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Debloated pkg #3139

wants to merge 3 commits into from

Conversation

SandZn
Copy link

@SandZn SandZn commented Jun 25, 2024

Context

Add a debloated version of package.json file, excluding unneeded dependencies that could bring extra maintenance costs and security risks.

Objective

During the test runtime, through our dynamic analysis, we tracked the OS system and found that 18 direct dependencies are installed, however, unused during the testing runtime.

So we figured out these dependencies, and try to remove them.

References

No references

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link

Coverage Status

coverage: 95.24%. remained the same
when pulling 64da81c on SandZn:debloated-pkg
into 68d0860 on screwdriver-cd:master.

@tanoda
Copy link

tanoda commented Jun 26, 2024

Some parts of this change will break the container uploaded to DockerHub. and sd-in-a-bos.
So, all (or most) screwdriver-* dependencies should be kept for installation.

@SandZn
Copy link
Author

SandZn commented Jun 26, 2024

Thanks for the response!

Some parts of this change will break [the container uploaded to DockerHub] (https://github.com/screwdriver-cd/screwdriver/blob/master/Dockerfile). and sd-in-a-bos.

I see. It seems that these dependencies are environment-related. Why not move these corresponding dependencies to devDependencies?

So, all (or most) screwdriver-* dependencies should be kept for installation.

Maybe a few of them are never needed, but are not removed from package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants