Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror Icons for RTL #249

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Mirror Icons for RTL #249

merged 1 commit into from
Nov 19, 2024

Conversation

Linfye
Copy link
Collaborator

@Linfye Linfye commented Nov 18, 2024

Contributor checklist


Description

According to the dev doc, I mirrored 2 icons and removed a duplicated icon (unused).

Related issue

Copy link

github-actions bot commented Nov 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review November 18, 2024 19:03
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @Linfye 🤩 Thank you for the quick fix and persistence to get RTL localization up to a very professional level!

@andrewtavis andrewtavis merged commit 7505add into scribe-org:main Nov 19, 2024
5 checks passed
@Linfye Linfye deleted the rtl-icon branch November 19, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants