Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style first autosuggestion button based on the gender of a word typed #277

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

This PR implements Gender | Plural auto suggestion for each word we type. This could be seen while typing a word and the first auto suggest button changes to the gender | PL for plural.

Related issue

Copy link

github-actions bot commented Dec 16, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Member Author

I am not sure if the color are similar. It would be helpful If I could get the colors used for iOS. Happy to make changes to make the PR perfect.

@andrewtavis
Copy link
Member

andrewtavis commented Dec 16, 2024

Amazing to see this, @angrezichatterbox! 🚀🚀🚀 This was the very first functionality of Scribe-iOS, and it's finally coming to Android 😊

A couple comments here:

  • The annotation should only be shown after the user presses space
  • We have the underlined annotations that are shown under autocompletions and suggestions as words are being typed, but the actual annotation should only be after space is pressed
  • Can we get the annotation to be styled a bit more
    • I think the autosuggestion buttons need a bit more space between them - say each is 95% (edited to 95 from 90) their current width, which will then translate to the annotation button
    • Can we get the corners to be a bit rounded
    • For now we don't need a shadow, but for preposition annotation we will need it, FYI (and eventually for this)
  • And here are the colors:
    • annotateRed: Light #9F1722; Dark #FB5F6C
    • annotateBlue: Light #335C99; Dark #339EEB
    • annotatePurple: Light #700589; Dark #AC6DEC
    • annotateGreen: Light #3D7946; Dark #85C26F
    • annotateOrange: Light #F85A39; Dark #FD9F5D
    • Can you name them as the above as well so we're consistent across the apps?

Let me know if there are any questions on the above!

@angrezichatterbox
Copy link
Member Author

Amazing to see this, @angrezichatterbox! 🚀🚀🚀 This was the very first functionality of Scribe-iOS, and it's finally coming to Android 😊

A couple comments here:

  • The annotation should only be shown after the user presses space

  • We have the underlined annotations that are shown under autocompletions and suggestions as words are being typed, but the actual annotation should only be after space is pressed

  • Can we get the annotation to be styled a bit more

    • I think the autosuggestion buttons need a bit more space between them - say each is 95% (edited to 95 from 90) their current width, which will then translate to the annotation button
    • Can we get the corners to be a bit rounded
    • For now we don't need a shadow, but for preposition annotation we will need it, FYI (and eventually for this)
  • And here are the colors:

    • annotateRed: Light #9F1722; Dark #FB5F6C
    • annotateBlue: Light #335C99; Dark #339EEB
    • annotatePurple: Light #700589; Dark #AC6DEC
    • annotateGreen: Light #3D7946; Dark #85C26F
    • annotateOrange: Light #F85A39; Dark #FD9F5D
    • Can you name them as the above as well so we're consistent across the apps?

Let me know if there are any questions on the above!

I will make these changes and sent in the updated PR :)

@andrewtavis
Copy link
Member

Looking forward, @angrezichatterbox!

@andrewtavis
Copy link
Member

Let me know when this is ready for a final review, @angrezichatterbox 😊

@angrezichatterbox
Copy link
Member Author

It is ready for review 😄

@andrewtavis
Copy link
Member

Nice! Will check it tonight or tomorrow :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really such a pleasure to bring this in, @angrezichatterbox 😊 Thanks so much for your dedication to the project :) :)

Minor changes will likely come in the future like making the characters of the annotations a bit larger than the autosuggestions, but this is all fine tuning that we can get to when we have some more progress and can start checking the Android app in direct comparison to the iOS one. Can't wait!

@andrewtavis andrewtavis merged commit e1bb782 into scribe-org:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants