-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style first autosuggestion button based on the gender of a word typed #277
Style first autosuggestion button based on the gender of a word typed #277
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
I am not sure if the color are similar. It would be helpful If I could get the colors used for iOS. Happy to make changes to make the PR perfect. |
Amazing to see this, @angrezichatterbox! 🚀🚀🚀 This was the very first functionality of Scribe-iOS, and it's finally coming to Android 😊 A couple comments here:
Let me know if there are any questions on the above! |
I will make these changes and sent in the updated PR :) |
Looking forward, @angrezichatterbox! |
Let me know when this is ready for a final review, @angrezichatterbox 😊 |
It is ready for review 😄 |
Nice! Will check it tonight or tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really such a pleasure to bring this in, @angrezichatterbox 😊 Thanks so much for your dedication to the project :) :)
Minor changes will likely come in the future like making the characters of the annotations a bit larger than the autosuggestions, but this is all fine tuning that we can get to when we have some more progress and can start checking the Android app in direct comparison to the iOS one. Can't wait!
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This PR implements Gender | Plural auto suggestion for each word we type. This could be seen while typing a word and the first auto suggest button changes to the gender | PL for plural.
Related issue