Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license tag to all Kotlin files (#282) #283

Closed
wants to merge 1 commit into from

Conversation

mat-in
Copy link
Contributor

@mat-in mat-in commented Dec 30, 2024

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@mat-in
Copy link
Contributor Author

mat-in commented Dec 30, 2024

Added license tags to all .kt files using bash

@mat-in mat-in closed this Dec 30, 2024
@andrewtavis
Copy link
Member

Hey @mat-in 👋 Looks like you might have ran your script multiple times. Can we only have the GPL as it is in the .swift file in the issue? Beyond that, it'd be great if we got a short description of what's in the file as the first line of the doc string as is in the .swift file. Would you be able to add those as well?

@mat-in
Copy link
Contributor Author

mat-in commented Dec 30, 2024

/**
 *{ Description}
 *
 * Copyright (C) 2024 Scribe
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

Hello! @andrewtavis
is this the format?

@andrewtavis
Copy link
Member

Exactly that, @mat-in :) Feel free to open a new PR or re-open this one with the changes!

@mat-in mat-in reopened this Dec 30, 2024
@mat-in mat-in closed this Dec 30, 2024
@mat-in mat-in deleted the add-license-tag branch December 30, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants