Use built-in sum instead of writing our own ad-hoc version
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self[1..] | ||
| .iter() | ||
| .fold(self[0].double(), |acc, coeff| acc + coeff) | ||
| self[0] + self[..].iter().sum::<E>() |
There was a problem hiding this comment.
Doubling the first element is a bit weird. But the tests seem to expect it. What's the reason for it?
@yczhangsjtu I think you wrote that code? Could you please enlighten me? (I'll probably make a documenting comment out of your answer later.) Thanks!
matthiasgoergens
changed the title
sum instead of writing our ownsum instead of writing our own ad-hoc version
chaosma
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #736 for ease of review.