refactor(rollup sync service): use `CalldataBlobSource` to retrieve data from L1 #1103

jonastheis · 2024-12-26T07:07:55Z

1. Purpose or design rationale of this PR

This PR refactors the rollup sync service to use CalldataBlobSource to retrieve data from L1. This removes a lot of duplicate code and makes future upgrades easier to support.

Specifically, before this PR the rollup sync service relied solely on the batch information contained in the commit transaction's calldata. However, with a future upgrade we will move this calldata to the blob. Therefore, the rollup sync service needs to be able to retrieve and interpret the blob data additionally.

This functionality is already given within the L1 follower mode which is why this PR reuses the internal component CalldataBlobSource to do this job. To support another upgrade (new batch version) changes need to be made only within CalldataBlobSource.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
docs: Documentation-only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
Yes

4. Breaking change label

Does this PR have the breaking-change label?

This PR is not a breaking change
Yes

…retrieve data from L1

coderabbitai · 2024-12-26T07:09:37Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

colinlyguo

nice work and LGTM.

rollup/rollup_sync_service/rollup_sync_service.go

colinlyguo · 2024-12-27T08:38:55Z

rollup/rollup_sync_service/rollup_sync_service.go

+	return &rawdb.CommittedBatchMeta{
+		Version:             uint8(commitedBatch.Version()),
+		ChunkBlockRanges:    chunkRanges,
+		BlobVersionedHashes: commitedBatch.BlobVersionedHashes(),


this field is dangling (used in previous versions but not used after da-codec refactoring), should (and could) we remove it as well?

Does removing it cause some problems for nodes that upgrade? And want to decode older data from DB?

I think you're right. some upgrade code would be added. what about keeping it as it is? (or add a comment in CommittedBatchMeta that this field is currently not used).

Done in 2499c69

rollup/rollup_sync_service/rollup_sync_service.go

rollup/rollup_sync_service/rollup_sync_service_test.go

rollup/rollup_sync_service/rollup_sync_service.go

rollup/rollup_sync_service/rollup_sync_service_test.go

refactor rollup sync service / verifier to use CalldataBlobSource to …

ab3e873

…retrieve data from L1

jonastheis added 2 commits December 27, 2024 08:32

add configuration and initialize blob clients

4ced6f2

fix unit tests

6aafa74

jonastheis marked this pull request as ready for review December 27, 2024 03:21

remove unused code

da81a2e

jonastheis force-pushed the jt/rollup-verifier-use-code-from-l1-follower branch from 6e06325 to da81a2e Compare December 27, 2024 03:27

colinlyguo reviewed Dec 27, 2024

View reviewed changes

rollup/rollup_sync_service/rollup_sync_service_test.go Show resolved Hide resolved

colinlyguo approved these changes Dec 27, 2024

View reviewed changes

jonastheis added 2 commits January 2, 2025 14:03

address review comments

8750045

address more review comments

2499c69

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(rollup sync service): use `CalldataBlobSource` to retrieve data from L1 #1103

refactor(rollup sync service): use `CalldataBlobSource` to retrieve data from L1 #1103

jonastheis commented Dec 26, 2024

coderabbitai bot commented Dec 26, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

colinlyguo left a comment

colinlyguo Dec 27, 2024

jonastheis Jan 2, 2025

colinlyguo Jan 2, 2025

jonastheis Jan 2, 2025

refactor(rollup sync service): use CalldataBlobSource to retrieve data from L1 #1103

Are you sure you want to change the base?

refactor(rollup sync service): use CalldataBlobSource to retrieve data from L1 #1103

Conversation

jonastheis commented Dec 26, 2024

1. Purpose or design rationale of this PR

2. PR title

3. Deployment tag versioning

4. Breaking change label

coderabbitai bot commented Dec 26, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

colinlyguo left a comment

Choose a reason for hiding this comment

colinlyguo Dec 27, 2024

Choose a reason for hiding this comment

jonastheis Jan 2, 2025

Choose a reason for hiding this comment

colinlyguo Jan 2, 2025

Choose a reason for hiding this comment

jonastheis Jan 2, 2025

Choose a reason for hiding this comment

refactor(rollup sync service): use `CalldataBlobSource` to retrieve data from L1 #1103

refactor(rollup sync service): use `CalldataBlobSource` to retrieve data from L1 #1103

coderabbitai bot commented Dec 26, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)