feat: scroll state provider #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
commented
Nov 9, 2024
Comment on lines
+203
to
+206
| #[cfg(feature = "scroll")] | ||
| code_size: 0, | ||
| #[cfg(feature = "scroll")] | ||
| poseidon_code_hash: B256::ZERO, |
There was a problem hiding this comment.
This is added as an intermediate solution in order for the clippy check to pass. Once the whole code base is migrated to use our ScrollAccountInfo, this can be removed.
greged93
force-pushed
the
greged93/feat/scroll-state-provider
branch
3 times, most recently
from
0b9285f to
0936180
Compare
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
greged93
force-pushed
the
greged93/feat/scroll-state-provider
branch
from
0936180 to
2a46a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a
ScrollStateProviderDatabase, a similar construct as theStateProviderDatabasebut providing a cache layer for the code size and the Poseidon code hash of every touched account's bytecode via theScrollPostExecutionContext(mapping from Keccak hash of an account's bytecode to the code size and Poseidon hash).Build towards #7 and should be reviewed after #30.