Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch pv digest hasher from sha256 to keccak #20

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Switch pv digest hasher from sha256 to keccak #20

merged 2 commits into from
Oct 29, 2024

Conversation

noel2004
Copy link
Member

No description provided.

@noel2004 noel2004 mentioned this pull request Oct 26, 2024
Closed
@lispc
Copy link

lispc commented Oct 28, 2024

a remainder, need to make sure the keccak is "patched" (using sp1 syscalls) correctly.

@noel2004
Copy link
Member Author

a remainder, need to make sure the keccak is "patched" (using sp1 syscalls) correctly.

Yes. The patch has been included in sproll-evm: https://github.com/scroll-tech/sproll-evm/blob/063aa3cab063bc5ff17b869adf44320139fa12ce/Cargo.toml#L52

@lispc lispc merged commit af8e2ac into scroll-dev-1019 Oct 29, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc lispc approved these changes

@roynalnaruto roynalnaruto Awaiting requested review from roynalnaruto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noel2004 @lispc