Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURESIGN-1174] Add Timestamp Authority #12

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[SECURESIGN-1174] Add Timestamp Authority #12

merged 3 commits into from
Jul 16, 2024

Conversation

fghanmi
Copy link
Collaborator

@fghanmi fghanmi commented Jul 15, 2024 •
edited
Loading

Add Timestamp Authority server on port 3002.
Updated vm_testing/test.sh to use it instead of Rekor TSA.

Testing command:

./vm_testing/test.sh

Expected Result: ...Verified OK

@fghanmi fghanmi requested a review from bkabrda July 15, 2024 06:57
bkabrda
bkabrda requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR, I think this looks very solid. I left few comments inline and I would also like to ask you to modify the test script under the vm-testing/ directory to test the timestamp server as well.

roles/tas_single_node/tasks/certificates.yml Outdated Show resolved Hide resolved
roles/tas_single_node/tasks/podman/tsa.yml Outdated Show resolved Hide resolved
@fghanmi fghanmi requested a review from bkabrda July 15, 2024 10:08
@fghanmi fghanmi requested a review from bkabrda July 15, 2024 11:46
@fghanmi fghanmi merged commit 0a80960 into main Jul 16, 2024
4 checks passed
@fghanmi fghanmi deleted the TSA branch July 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkabrda bkabrda bkabrda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fghanmi @bkabrda