Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fixes and improvements for the vm-testing setup #16

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore: Fixes and improvements for the vm-testing setup #16

merged 1 commit into from
Jul 26, 2024

Conversation

bkabrda
Copy link
Collaborator

@bkabrda bkabrda commented Jul 26, 2024

This PR improves/fixes the vm-testing setup:

  • Properly overwrite the inventory file regardless where we're calling the provision.sh script from
  • Properly set up becoming root in the inventory
  • Verify the blob in verbose mode

@fghanmi fghanmi self-requested a review July 26, 2024 08:34
fghanmi
fghanmi approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@fghanmi fghanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bkabrda bkabrda merged commit 8e35546 into main Jul 26, 2024
4 checks passed
@bkabrda bkabrda deleted the slavek.kabrda/fix-vm-testing branch September 24, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fghanmi fghanmi fghanmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkabrda @fghanmi